----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review128367 -----------------------------------------------------------
Fix it, then Ship it! I'll adjust the comment and commit description and then commit it for you. src/tests/log_tests.cpp (line 1870) <https://reviews.apache.org/r/43524/#comment191803> s/is is/are in Also we backtick variables and types - Alexander Rukletsov On April 9, 2016, 4:11 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43524/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 4:11 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and haosdent huang. > > > Bugs: MESOS-4160 > https://issues.apache.org/jira/browse/MESOS-4160 > > > Repository: mesos > > > Description > ------- > > Speeded up RecoverTest.AutoInitialization by advacing the clock. > > > Diffs > ----- > > src/tests/log_tests.cpp 8f208bac13a7276074278213119d8894766e84ea > > Diff: https://reviews.apache.org/r/43524/diff/ > > > Testing > ------- > > `$ sudo make check -j2 GTEST_FILTER='RecoverTest.AutoInitialization'` > > ```sh > [----------] 1 test from RecoverTest > [ RUN ] RecoverTest.AutoInitialization > [ OK ] RecoverTest.AutoInitialization (630 ms) > [----------] 1 test from RecoverTest (631 ms total) > ``` > > Repeatly tested with: > > ``` > ./bin/mesos-tests.sh --gtest_filter=RecoverTest.AutoInitialization > --gtest_repeat=1000 --gtest_break_on_failure' > ``` > > > Thanks, > > Shuai Lin > >
