----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45927/#review127829 -----------------------------------------------------------
src/cli/execute.cpp (lines 639 - 651) <https://reviews.apache.org/r/45927/#comment191209> Given how these flags are pretty much all passed into the `CommandScheduler`, can you add another patch that changes the constructor signature to something like: ``` Command(const Flags& _flags) : flags(flags) { ... } ``` - Joseph Wu On April 8, 2016, 5:39 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45927/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 5:39 a.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-5124 > https://issues.apache.org/jira/browse/MESOS-5124 > > > Repository: mesos > > > Description > ------- > > Adds a flag that specifies a delay after which the task should be > killed. If set, a kill task request is scheduled to be sent after > TASK_RUNNING status update has been received. Also adds support for > TASK_KILLING capability. > > > Diffs > ----- > > src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 > > Diff: https://reviews.apache.org/r/45927/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `make check` > > Additionally manually tested `mesos-execute` with both responsive and > unresponsive (https://github.com/rukletsov/unresponsive-process) tasks: > `./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" > --env='{"GLOG_v": 2}'` > `./src/mesos-execute --master=127.0.0.1:5050 --name=test > --command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": 2}'` > > > Thanks, > > Alexander Rukletsov > >
