> On April 9, 2016, 2:32 a.m., Guangya Liu wrote:
> > src/cli/execute.cpp, line 157
> > <https://reviews.apache.org/r/45927/diff/1/?file=1337077#file1337077line157>
> >
> >     I can see many people ask the format of `time` in user list, it would 
> > be great if we can list all supported unit here.
> >     
> >     
> > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp#L53-L68

Instead of doing it on per-flag basis, how about updating it in one place, 
specifically 
https://github.com/apache/mesos/blob/4dfa91fc21f80204f5125b2e2f35c489f8fb41d8/3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp#L70
 ? Do you want to file a JIRA? I'll be happy to shepherd.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45927/#review127946
-----------------------------------------------------------


On April 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45927/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5124
>     https://issues.apache.org/jira/browse/MESOS-5124
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a flag that specifies a delay after which the task should be
> killed. If set, a kill task request is scheduled to be sent after
> TASK_RUNNING status update has been received. Also adds support for
> TASK_KILLING capability.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/45927/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `make check`
> 
> Additionally manually tested `mesos-execute` with both responsive and 
> unresponsive (https://github.com/rukletsov/unresponsive-process) tasks:
> `./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" 
> --env='{"GLOG_v": 2}'`
> `./src/mesos-execute --master=127.0.0.1:5050 --name=test 
> --command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": 2}'`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to