> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 16 > > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line16> > > > > the previous version was working fine on ubuntu and centos. why the > > change? > > Juan Larriba wrote: > It is not working for me on Ubuntu:14.04 and Ubuntu:15.10: > > [root@jlarriba ~]# dirname "$0" > dirname: invalid option -- 'b' > Try 'dirname --help' for more information. > > [root@jlarriba ~]# dirname -- "$0" > . > > Vinod Kone wrote: > $0 is a bash variable that corresponds to the path of the bash script > itself. When `dirname $0` is executed in the script, $0 is the path of the > docker_build.sh script. > > ``` > vagrant@vagrant-ubuntu-trusty-64:~$ dirname /foo/bar > /foo > vagrant@vagrant-ubuntu-trusty-64:~$ dirname abc > . > ```
OK, I remove this change. > On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 115 > > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line115> > > > > How about > > > > # NOTE: Enviornment is currently ignored by CMake build because tests > > are not run. That line should not be there - Juan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127677 ----------------------------------------------------------- On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45668/ > ----------------------------------------------------------- > > (Updated Abr. 8, 2016, 10:41 p.m.) > > > Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-5101 > https://issues.apache.org/jira/browse/MESOS-5101 > > > Repository: mesos > > > Description > ------- > > Enable CMake build for Linux as new CONFIGURATOR option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Diffs > ----- > > support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d > > Diff: https://reviews.apache.org/r/45668/diff/ > > > Testing > ------- > > Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both > cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in > centos:7 only gcc. > > > Thanks, > > Juan Larriba > >
