> On Abr. 8, 2016, 10:55 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 123 > > <https://reviews.apache.org/r/45668/diff/3/?file=1337709#file1337709line123> > > > > Remove the trailing white space and put a period at the end. Also wrap > > at 80 chars. > > > > Also I would rephrase this as follows: > > > > # Building inside the source directory and distcheck are not currently > > supported > > # by our CMake scripts. See MESOS-3108 for details. > > Vinod Kone wrote: > Also, can you rebase?
Build inside the source directory is actually supported, it just seemed cleaner to me build in a different directory. But I will change it to build on the source directory. - Juan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127912 ----------------------------------------------------------- On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45668/ > ----------------------------------------------------------- > > (Updated Abr. 8, 2016, 10:41 p.m.) > > > Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-5101 > https://issues.apache.org/jira/browse/MESOS-5101 > > > Repository: mesos > > > Description > ------- > > Enable CMake build for Linux as new CONFIGURATOR option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Enable CMake build for Linux as a BUILDTOOL option. > > > Diffs > ----- > > support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d > > Diff: https://reviews.apache.org/r/45668/diff/ > > > Testing > ------- > > Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both > cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in > centos:7 only gcc. > > > Thanks, > > Juan Larriba > >
