----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/#review127960 -----------------------------------------------------------
include/mesos/mesos.proto (line 756) <https://reviews.apache.org/r/45958/#comment191353> s/containers/tasks ? Tasks may be more clear here. include/mesos/mesos.proto (line 757) <https://reviews.apache.org/r/45958/#comment191350> What about `ShareableInfo`? This is also consistent with `RevocableInfo`. include/mesos/mesos.proto (line 759) <https://reviews.apache.org/r/45958/#comment191354> s/i.e./i.e., include/mesos/mesos.proto (line 761) <https://reviews.apache.org/r/45958/#comment191351> Can you please add a note here that this pareameter is only work for persiste volume for now? include/mesos/mesos.proto (line 762) <https://reviews.apache.org/r/45958/#comment191352> s/optional ShareInfo share/optional ShareableInfo shareable - Guangya Liu On 四月 8, 2016, 11:16 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45958/ > ----------------------------------------------------------- > > (Updated 四月 8, 2016, 11:16 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4892 > https://issues.apache.org/jira/browse/MESOS-4892 > > > Repository: mesos > > > Description > ------- > > Added ShareInfo in Resource protobuf to allow for sharing of resources. > > > Diffs > ----- > > include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 > include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f > > Diff: https://reviews.apache.org/r/45958/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
