> On April 9, 2016, 12:08 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 756 > > <https://reviews.apache.org/r/45958/diff/1/?file=1337790#file1337790line756> > > > > s/containers/tasks ? Tasks may be more clear here.
+1. There are quite a number of details about how tasks and containers relate here w.r.t shared resources (e.g., even within a container multiple tasks can use the same shared resource) but here I think to avoid getting into too much details `tasks` is easier to understand and is certainly correct. > On April 9, 2016, 12:08 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 761 > > <https://reviews.apache.org/r/45958/diff/1/?file=1337790#file1337790line761> > > > > Can you please add a note here that this pareameter is only work for > > persiste volume for now? +1. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/#review127960 ----------------------------------------------------------- On April 8, 2016, 4:16 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45958/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 4:16 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4892 > https://issues.apache.org/jira/browse/MESOS-4892 > > > Repository: mesos > > > Description > ------- > > Added ShareInfo in Resource protobuf to allow for sharing of resources. > > > Diffs > ----- > > include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 > include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f > > Diff: https://reviews.apache.org/r/45958/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
