> On 四月 8, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > src/tests/hook_tests.cpp, line 392 > > <https://reviews.apache.org/r/42241/diff/5/?file=1258988#file1258988line392> > > > > we don't need `settle` here because AWAIT_READY does it for us. > > However, we should resume the clock since in the future we may have a check > > that the clock is unpaused when test finishes.
Since we explicitly destroy the container, there is no need to pause/resume clock here. - Jian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review127792 ----------------------------------------------------------- On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42241/ > ----------------------------------------------------------- > > (Updated 四月 9, 2016, 2:45 p.m.) > > > Review request for mesos, Alexander Rukletsov and Timothy Chen. > > > Bugs: MESOS-4174 > https://issues.apache.org/jira/browse/MESOS-4174 > > > Repository: mesos > > > Description > ------- > > Speed up HookTest.VerifySlaveLaunchExecutorHook. > > > Diffs > ----- > > src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 > > Diff: https://reviews.apache.org/r/42241/diff/ > > > Testing > ------- > > Before > HookTest.VerifySlaveLaunchExecutorHook (5061 ms) > > After > HookTest.VerifySlaveLaunchExecutorHook (132 ms) > > > Thanks, > > Jian Qiu > >
