----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45941/#review128005 -----------------------------------------------------------
Patch looks great! Reviews applied: [45941] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 9, 2016, 5:20 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45941/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 5:20 p.m.) > > > Review request for mesos, Ben Mahler and Joseph Wu. > > > Bugs: MESOS-5131 > https://issues.apache.org/jira/browse/MESOS-5131 > > > Repository: mesos > > > Description > ------- > > Add check in agent for incorrect oversubscribed resource. > > > Diffs > ----- > > src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 > > Diff: https://reviews.apache.org/r/45941/diff/ > > > Testing > ------- > > Running existing test, and verify manually that offending resource crashes > the agent. > > (Any suggestion to test `CHECK` is welcomed). > > > Thanks, > > Zhitao Li > >
