-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review128033
-----------------------------------------------------------




docs/container-image.md (lines 290 - 291)
<https://reviews.apache.org/r/45358/#comment191433>

    It is better update the document here to highlight that the overlay backend 
also support one layer image now.
    
    The overlay backend allows containizer to utilize the filesystem to merge 
multiple filesystems into one efficiently. NOTE: The overlay backend support 
both one layer and multiple layer image.



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (lines 50 - 52)
<https://reviews.apache.org/r/45358/#comment191432>

    4 spaces



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 297)
<https://reviews.apache.org/r/45358/#comment191430>

    4 spaces



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 300)
<https://reviews.apache.org/r/45358/#comment191431>

    4 spaces


- Guangya Liu


On 四月 10, 2016, 8:09 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> -----------------------------------------------------------
> 
> (Updated 四月 10, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
>     https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 07581f6ac714485e9c743984a553bb6fb26756b7 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> -------
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to