----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/#review128039 -----------------------------------------------------------
include/mesos/docker/spec.hpp (lines 77 - 79) <https://reviews.apache.org/r/45949/#comment191435> Result<std::string> getCredential( const JSON::Object& config, const std::string& registry); src/docker/spec.cpp (line 153) <https://reviews.apache.org/r/45949/#comment191436> const JSON::Object& config src/docker/spec.cpp (lines 163 - 164) <https://reviews.apache.org/r/45949/#comment191455> one line? src/docker/spec.cpp (lines 172 - 175) <https://reviews.apache.org/r/45949/#comment191458> I did not found any link which telling me that "many registry domain recorded in docker config file does not start with 'https://' or 'http://'", can you please put a link here as reference? - Guangya Liu On 四月 8, 2016, 9:49 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45949/ > ----------------------------------------------------------- > > (Updated 四月 8, 2016, 9:49 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Implemented docker config get credential helper. > > > Diffs > ----- > > include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 > src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d > > Diff: https://reviews.apache.org/r/45949/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
