----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/#review128079 -----------------------------------------------------------
src/docker/spec.cpp (line 188) <https://reviews.apache.org/r/45949/#comment191472> What about adding a log to say that the fetcher will use this auth to fetch image? src/docker/spec.cpp (line 192) <https://reviews.apache.org/r/45949/#comment191473> What about adding some log here to say that the auth will be iognored? - Guangya Liu On 四月 8, 2016, 9:49 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45949/ > ----------------------------------------------------------- > > (Updated 四月 8, 2016, 9:49 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Implemented docker config get credential helper. > > > Diffs > ----- > > include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 > src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d > > Diff: https://reviews.apache.org/r/45949/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
