> On April 11, 2016, 9:55 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 559-562 > > <https://reviews.apache.org/r/46027/diff/1/?file=1339342#file1339342line559> > > > > Hm.. this may be a bit confusing for those without context. A > > libprocess message can be sent by either libprocess itself, or by clients > > that speak libprocess. Here the distinction is that this will tell you if > > this is a libprocess message *and* it is sent by a libprocess instance.
I believe the function tells you OR, not AND -- i.e., it returns true if the message was sent by another libprocess instance, or by another client that speaks the libprocess protocol. Comment updated to clarify this. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/#review128266 ----------------------------------------------------------- On April 11, 2016, 2:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46027/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:35 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > This is a bit confusing, because different libprocess HTTP > clients set different headers. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46027/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
