> On April 13, 2016, 9:33 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, line 559 > > <https://reviews.apache.org/r/46027/diff/2/?file=1340142#file1340142line559> > > > > s/. A/. A/ > > > > Thanks for clarifying, sorry for the confusion! > > Ben Mahler wrote: > Also, would you mind wrapping comments at 70 to stay consistent with most > of our existing code? > > ``` > // Returns true if `request` contains an inbound libprocess message. > // A libprocess message can either be sent by another instance of > // libprocess (i.e. both of the "User-Agent" and "Libprocess-From" > // headers will be set), or a client that speaks the libprocess > // protocol (i.e. only the "Libprocess-From" header will be set). > // This function returns true for either case. > ```
Per commit f9c2604ea97b91f8a9ec3b2863317761679b1c86, I thought that wasn't a requirement anymore? - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/#review128749 ----------------------------------------------------------- On April 12, 2016, 12:23 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46027/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 12:23 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > This is a bit confusing, because different libprocess HTTP > clients set different headers. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46027/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
