-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128411
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 80)
<https://reviews.apache.org/r/45987/#comment191833>

    2 spaces for expression continuation.



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 176)
<https://reviews.apache.org/r/45987/#comment191834>

    Can you explain why this is not defined on windows?


- Joris Van Remoortere


On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 10:34 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed `rmdir.hpp` Windows build breaks.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> dd5cc6923ecc503d58e56128cf4ae736d8145fd7 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 
> cc92953ccc53f37c54b87e738b16ea1fb521b987 
> 
> Diff: https://reviews.apache.org/r/45987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to