> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179
> > <https://reviews.apache.org/r/45987/diff/1/?file=1338480#file1338480line179>
> >
> >     Can you explain why this is not defined on windows?

Well, I don't know how to port it to Windows. It is not clear to me that `rdev` 
or `mknod` make much sense to Windows. You might be able to make a totally 
different test that makes this work, but after spending an hour or two on it I 
decided that it is more important to make progress on other issues instead.

Thoughts? Do you think it is important to port it right now?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128411
-----------------------------------------------------------


On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 10:34 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed `rmdir.hpp` Windows build breaks.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> dd5cc6923ecc503d58e56128cf4ae736d8145fd7 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 
> cc92953ccc53f37c54b87e738b16ea1fb521b987 
> 
> Diff: https://reviews.apache.org/r/45987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to