> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 68
> > <https://reviews.apache.org/r/46097/diff/1/?file=1341409#file1341409line68>
> >
> >     `hostname -i` might return multiple IP. For example on my Ubuntu 14.04, 
> > this is the output I see:
> >     hostname -i
> >     10.0.2.15 172.28.128.7 172.18.0.1 192.168.1.1 172.17.0.1 192.168.0.1
> >     
> >     So wouldn't this cause a problem with the creation of the JSON output?

Yeah, that's a problem, maybe we should just grab the first one?


> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 146
> > <https://reviews.apache.org/r/46097/diff/1/?file=1341409#file1341409line146>
> >
> >     Can we check if the checkpointed information is correctly cleaned up 
> > after the the TASK has finished.

Ditto.


> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 143
> > <https://reviews.apache.org/r/46097/diff/1/?file=1341409#file1341409line143>
> >
> >     Can we make the task long running, and then check that the CNI network 
> > information has been correctly checkpointed in the host file system.

If the output of the CNI plugin is not correctly checkpointed for the 
container, then we should receive a TASK_FAILED rather than TASK_RUNNING or 
TASK_FINISHED which are expected by this test, so I think this test already 
catches this, right?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review128446
-----------------------------------------------------------


On April 12, 2016, 10:54 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46097/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 10:54 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
>     https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for 'network/cni' isolator.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46097/diff/
> 
> 
> Testing
> -------
> 
> $ sudo make check GTEST_FILTER="CniIsolatorTest.ROOT_LaunchCommandTask"
> ...
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CniIsolatorTest
> [ RUN      ] CniIsolatorTest.ROOT_LaunchCommandTask
> + /home/stack/workspace/mesos/build/src/mesos-containerizer mount 
> --help=false --operation=make-rslave --path=/
> + + + cut -d  -f5
> grep -v 3fb389d5-77b2-48bd-af69-c6385b3296c5
> + xargs --no-run-if-empty umount -l
> grep -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_BPuada/.+ 
> /proc/self/mountinfo
> + mount -n --rbind 
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_BPuada/provisioner/containers/3fb389d5-77b2-48bd-af69-c6385b3296c5/backends/copy/rootfses/12adf695-4a56-4531-8365-1dea7842a330
>  
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_BPuada/slaves/d1d9bb40-b122-4adb-8a84-3ead09f81b58-S0/frameworks/d1d9bb40-b122-4adb-8a84-3ead09f81b58-0000/executors/559e79c5-dc46-46eb-a6ea-0bd2c79947b3/runs/3fb389d5-77b2-48bd-af69-c6385b3296c5/.rootfs
> I0412 22:39:49.079829 20962 exec.cpp:150] Version: 0.29.0
> I0412 22:39:49.100260 21018 exec.cpp:225] Executor registered on agent 
> d1d9bb40-b122-4adb-8a84-3ead09f81b58-S0
> Registered executor on mesos
> Starting task 559e79c5-dc46-46eb-a6ea-0bd2c79947b3
> Forked command at 21020
> [echo, echo, hello world]
> hello world
> Command exited with status 0 (pid: 21020)
> I0412 22:39:49.239095 21016 exec.cpp:399] Executor asked to shutdown
> [       OK ] CniIsolatorTest.ROOT_LaunchCommandTask (33871 ms)
> [----------] 1 test from CniIsolatorTest (33891 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (33906 ms total)
> [  PASSED  ] 1 test.
> ...
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to