> On 四月 4, 2016, 11:16 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp, line 28 > > <https://reviews.apache.org/r/45270/diff/4/?file=1322998#file1322998line28> > > > > Should we add a inline parse method here?
Seems not as the dvd isolator do not need to parse some JSON files. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review126968 ----------------------------------------------------------- On 四月 2, 2016, 5:52 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45270/ > ----------------------------------------------------------- > > (Updated 四月 2, 2016, 5:52 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Added spec protobut for external mount. > > > Diffs > ----- > > src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/45270/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
