-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128922
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 19)
<https://reviews.apache.org/r/45270/#comment192360>

    above `import "mesos/mesos.proto";`



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (lines 26 - 27)
<https://reviews.apache.org/r/45270/#comment192369>

    This field make me feel confused, since we also have a `conainer_path` 
field in volume as a required string. Should they be identical? If yes, we 
should comment it.



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 34)
<https://reviews.apache.org/r/45270/#comment192371>

    +1 on parameters.


- Gilbert Song


On April 13, 2016, 9:41 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:41 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to