> On 四月 4, 2016, 11:37 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, line 54 > > <https://reviews.apache.org/r/45360/diff/2/?file=1323003#file1323003line54> > > > > `driver_options` is an optional field, right? This may lead to segfault.
This type is now changed to `repeated parameter` - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review126971 ----------------------------------------------------------- On 四月 13, 2016, 9:17 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45360/ > ----------------------------------------------------------- > > (Updated 四月 13, 2016, 9:17 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added dvd client for mount and unmount. > > > Diffs > ----- > > src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 > src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45360/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >