> On 四月 4, 2016, 11:37 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, lines > > 67-71 > > <https://reviews.apache.org/r/45360/diff/2/?file=1323003#file1323003line67> > > > > could we set `dvdcliPath + /dvdcli` as cmd, and append the rest as argv?
I was following the docker executor here because I saw that the cmd is not very long, so I was using a simple way here, what do you think? The docker refererence: https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L733-L742 > On 四月 4, 2016, 11:37 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, line 77 > > <https://reviews.apache.org/r/45360/diff/2/?file=1323003#file1323003line77> > > > > Should we user await()? > > > > ``` > > reutrn await( > > s.get().status(), > > io::read(s.get().out().get()), > > io::read(s.get().err().get())) > > .then(...) > > ``` Yes, I was a bit confused here, I also think that we should add `await` here, but I saw some places using `await` while some not, can you help clarify? ;-) Not using `await`: https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L748 Using `await`: https://github.com/apache/mesos/blob/master/src/common/command_utils.cpp#L62 - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review126971 ----------------------------------------------------------- On 四月 2, 2016, 5:56 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45360/ > ----------------------------------------------------------- > > (Updated 四月 2, 2016, 5:56 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added dvd client for mount and unmount. > > > Diffs > ----- > > src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45360/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >