-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46139/#review128873
-----------------------------------------------------------



This'll do quite nicely once we address these issues.


src/tests/dynamic_weights_tests.cpp (lines 114 - 118)
<https://reviews.apache.org/r/46139/#comment192334>

    Why are role2 and role1 in reverse order? Is this always the case? Why 
wouldn't it be forward-alphabetical order?



src/tests/dynamic_weights_tests.cpp (line 622)
<https://reviews.apache.org/r/46139/#comment192335>

    Seems strange that this one is still UPDATED_WEIGHTS2 (which doesn't 
include role2), but then just restarting the master (with no weights flag) 
causes role2 to show up and /weights to return UPDATED_WEIGHTS3 data.
    I'd expect checkWithGetRequest to only use U_W1 or U_W3, never U_W2.
    Maybe this is why ReviewBot reported RecoveredWeightsFromRegistry as 
failing.


- Adam B


On April 12, 2016, 11:10 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46139/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4316
>     https://issues.apache.org/jira/browse/MESOS-4316
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add positive tests for /weights endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/dynamic_weights_tests.cpp 
> f89b89dd2553220161e28ec4784eb0bbdfdb65fe 
> 
> Diff: https://reviews.apache.org/r/46139/diff/
> 
> 
> Testing
> -------
> 
> make && make check.
> 
> Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests 
> --gtest_filter=DynamicWeightsTest.*
> [==========] Running 13 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 13 tests from DynamicWeightsTest
> [ RUN      ] DynamicWeightsTest.PutInvalidRequest
> [       OK ] DynamicWeightsTest.PutInvalidRequest (89 ms)
> [ RUN      ] DynamicWeightsTest.ZeroWeight
> [       OK ] DynamicWeightsTest.ZeroWeight (39 ms)
> [ RUN      ] DynamicWeightsTest.NegativeWeight
> [       OK ] DynamicWeightsTest.NegativeWeight (46 ms)
> [ RUN      ] DynamicWeightsTest.NonNumericWeight
> [       OK ] DynamicWeightsTest.NonNumericWeight (39 ms)
> [ RUN      ] DynamicWeightsTest.MissingRole
> [       OK ] DynamicWeightsTest.MissingRole (37 ms)
> [ RUN      ] DynamicWeightsTest.UnknownRole
> [       OK ] DynamicWeightsTest.UnknownRole (32 ms)
> [ RUN      ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [       OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN      ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [       OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN      ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest
> [       OK ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest (35 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (42 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [       OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (41 ms)
> [ RUN      ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (40 ms)
> [ RUN      ] DynamicWeightsTest.RecoveredWeightsFromRegistry
> [       OK ] DynamicWeightsTest.RecoveredWeightsFromRegistry (135 ms)
> [----------] 13 tests from DynamicWeightsTest (659 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 13 tests from 1 test case ran. (669 ms total)
> [  PASSED  ] 13 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Reply via email to