-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46139/
-----------------------------------------------------------

(Updated April 19, 2016, 1:42 p.m.)


Review request for mesos and Adam B.


Changes
-------

Address the comments of Adam.


Bugs: MESOS-4316
    https://issues.apache.org/jira/browse/MESOS-4316


Repository: mesos


Description
-------

Add positive tests for /weights endpoint.


Diffs (updated)
-----

  src/tests/dynamic_weights_tests.cpp f89b89dd2553220161e28ec4784eb0bbdfdb65fe 
  src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 

Diff: https://reviews.apache.org/r/46139/diff/


Testing
-------

make && make check.

Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests 
--gtest_filter=DynamicWeightsTest.*
[==========] Running 13 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 13 tests from DynamicWeightsTest
[ RUN      ] DynamicWeightsTest.PutInvalidRequest
[       OK ] DynamicWeightsTest.PutInvalidRequest (89 ms)
[ RUN      ] DynamicWeightsTest.ZeroWeight
[       OK ] DynamicWeightsTest.ZeroWeight (39 ms)
[ RUN      ] DynamicWeightsTest.NegativeWeight
[       OK ] DynamicWeightsTest.NegativeWeight (46 ms)
[ RUN      ] DynamicWeightsTest.NonNumericWeight
[       OK ] DynamicWeightsTest.NonNumericWeight (39 ms)
[ RUN      ] DynamicWeightsTest.MissingRole
[       OK ] DynamicWeightsTest.MissingRole (37 ms)
[ RUN      ] DynamicWeightsTest.UnknownRole
[       OK ] DynamicWeightsTest.UnknownRole (32 ms)
[ RUN      ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[       OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN      ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[       OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN      ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest
[       OK ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest (35 ms)
[ RUN      ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[       OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (42 ms)
[ RUN      ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[       OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
(41 ms)
[ RUN      ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[       OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (40 ms)
[ RUN      ] DynamicWeightsTest.RecoveredWeightsFromRegistry
[       OK ] DynamicWeightsTest.RecoveredWeightsFromRegistry (135 ms)
[----------] 13 tests from DynamicWeightsTest (659 ms total)

[----------] Global test environment tear-down
[==========] 13 tests from 1 test case ran. (669 ms total)
[  PASSED  ] 13 tests.


Thanks,

Yongqiao Wang

Reply via email to