----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review128925 -----------------------------------------------------------
src/master/flags.cpp (lines 225 - 226) <https://reviews.apache.org/r/46211/#comment192365> This seems a tiny bit misleading: if the value is `false`, no authentication will be performed at all. Perhaps something like "If `false`, HTTP frameworks are not authenticated." src/master/master.cpp (lines 665 - 673) <https://reviews.apache.org/r/46211/#comment192372> This can be moved into the `if (flags.authenticate_http_frameworks)` scope, as well as the above declaration of `httpFrameworkAuthenticator`. - Greg Mann On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46211/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 3:34 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3923 > https://issues.apache.org/jira/browse/MESOS-3923 > > > Repository: mesos > > > Description > ------- > > This change introduces two new flags `authenticate_http_frameworks` > and `http_framework_authenticators` to the master. This allows us > to selectively turn on/off framework authentication and decouple > them from authentication for operator endpoints. > > > Diffs > ----- > > src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 > src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 > src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c > src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c > > Diff: https://reviews.apache.org/r/46211/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
