----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129044 -----------------------------------------------------------
src/master/constants.hpp (line 132) <https://reviews.apache.org/r/46211/#comment192504> If and when we add AuthN support for agent <-> executor, what is that realm going to be? 'mesos-http-framework' or 'mesos-http-executor'? I guess it has to the latter because we bring up both master and agent in the same OS process in tests? so should this be called mesos-http-scheduler instead? it's kinda unfortunate that we sometimes equate framework with scheduler and sometimes with framework and executor. src/master/flags.cpp (line 482) <https://reviews.apache.org/r/46211/#comment192505> do we need a default here? we needed a default for `--http_authenticators` for backwards compatibility. since there is no backwards compatibility concern here, i think we should be ok with no default? having a default and not loading is a bit weird IMO. remove the default and mention in the description that this flag is required iff `--authenticate_http_frameworks` is set. src/master/master.cpp (line 448) <https://reviews.apache.org/r/46211/#comment192506> Master allowing HTTP frameworks to register without authentication src/master/master.cpp (line 674) <https://reviews.apache.org/r/46211/#comment192507> this whole logic can be cleaned up a bit if we make the flag required as suggested. - Vinod Kone On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46211/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 3:34 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3923 > https://issues.apache.org/jira/browse/MESOS-3923 > > > Repository: mesos > > > Description > ------- > > This change introduces two new flags `authenticate_http_frameworks` > and `http_framework_authenticators` to the master. This allows us > to selectively turn on/off framework authentication and decouple > them from authentication for operator endpoints. > > > Diffs > ----- > > src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 > src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 > src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c > src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c > > Diff: https://reviews.apache.org/r/46211/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
