-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46364/#review129486
-----------------------------------------------------------



can you also update cli/execute.cpp, examples/test_http_framework.cpp, 
examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, 
master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp?

make sure to grep through the code base to catch all other cases where switch 
over an enum uses a "default".


src/examples/test_http_executor.cpp (line 193)
<https://reviews.apache.org/r/46364/#comment192918>

    Instead of UNREACHABLE() you should log a warning and ignore it. This is 
what we expect real world executors and schedulers to do.



src/tests/mesos.hpp (line 957)
<https://reviews.apache.org/r/46364/#comment192920>

    see above.



src/tests/mesos.hpp (line 1084)
<https://reviews.apache.org/r/46364/#comment192919>

    see above.


w

- Vinod Kone


On April 19, 2016, 3:28 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46364/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-5031
>     https://issues.apache.org/jira/browse/MESOS-5031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
> 
> This patch is related to:
> https://reviews.apache.org/r/45317/ (MESOS-5014)
> https://reviews.apache.org/r/45304/ (MESOS-5015)
> https://reviews.apache.org/r/45342/ (MESOS-5031)
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp 
> c744a16041c2466d3839a37fbee2bf86887bf4e1 
>   src/examples/test_http_executor.cpp 
> ceb489d43f35d24c8a7f5fbb0148529745ee357a 
>   src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 
> 
> Diff: https://reviews.apache.org/r/46364/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to