----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129948 -----------------------------------------------------------
src/examples/test_http_framework.cpp (line 187) <https://reviews.apache.org/r/46364/#comment193499> kill this? src/master/http.cpp (line 549) <https://reviews.apache.org/r/46364/#comment193507> Remove this comment. src/master/http.cpp (lines 550 - 551) <https://reviews.apache.org/r/46364/#comment193501> s/Unexpected// src/master/http.cpp (lines 553 - 554) <https://reviews.apache.org/r/46364/#comment193500> move this to the top of the switch statement cases. Also instead of UNREACHABLE this should be LOG(FATAL) src/master/master.cpp (lines 2123 - 2131) <https://reviews.apache.org/r/46364/#comment193502> ditto. see above. src/master/validation.cpp (line 155) <https://reviews.apache.org/r/46364/#comment193504> This should be a return None() so that `scheduler()` can return a NotImplemented() instead of BadRequest(). src/master/validation.cpp (lines 157 - 158) <https://reviews.apache.org/r/46364/#comment193503> move this to the top and change this to LOG(FATAL). src/master/validation.cpp (line 161) <https://reviews.apache.org/r/46364/#comment193505> Shouldn't this be UNREACHABLE() ? src/slave/http.cpp (line 329) <https://reviews.apache.org/r/46364/#comment193506> ditto. see my comments above for master/http.cpp. src/slave/http.cpp (line 335) <https://reviews.apache.org/r/46364/#comment193508> UNREACHABLE() ? src/slave/validation.cpp (lines 103 - 107) <https://reviews.apache.org/r/46364/#comment193509> ditto. see my comments in master/validation.cpp src/tests/mesos.hpp (line 957) <https://reviews.apache.org/r/46364/#comment193510> I think we can do LOG(FATAL) in tests because we don't expect to receive UNKNWON events. LOG(FATAL) << "Received unexpected UNKNOWN event"; src/tests/mesos.hpp (lines 1084 - 1086) <https://reviews.apache.org/r/46364/#comment193511> ditto. see above. - Vinod Kone On April 21, 2016, 2:28 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46364/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 2:28 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-5014 and MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5014 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > ------- > > This patch changes from `default` statement to explicit case > statement (`UNKNOWN`) so that complier could help catching all > switches when new enums are introduced in the future. > > This patch is related to: > https://reviews.apache.org/r/45317/ (MESOS-5014) > https://reviews.apache.org/r/45304/ (MESOS-5015) > > > Diffs > ----- > > src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb > src/examples/long_lived_executor.cpp > ebb9cbf578d79fd87ac51ea85575950b7c0a1504 > src/examples/long_lived_framework.cpp > c696ccb6b2ace6e047f6509b291dd14be240cf70 > src/examples/test_http_executor.cpp > ceb489d43f35d24c8a7f5fbb0148529745ee357a > src/examples/test_http_framework.cpp > 8cc3107034d46cb6a2966835f509508223c6e674 > src/launcher/http_command_executor.cpp > ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac > src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 > src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 > src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 > src/sched/sched.cpp 5393f0de655d03ac1a31b3144d4d764d4aeb56fb > src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c > src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > > Diff: https://reviews.apache.org/r/46364/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
