----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review129507 -----------------------------------------------------------
src/slave/http.cpp (lines 358 - 359) <https://reviews.apache.org/r/46203/#comment192944> for readability in this case you could indent to the parenthesis on the `.then(`. It is allowed by the styleguide if you ask yourself src/slave/http.cpp (lines 360 - 362) <https://reviews.apache.org/r/46203/#comment192942> Formatting is wrong src/slave/http.cpp (lines 658 - 659) <https://reviews.apache.org/r/46203/#comment192943> Whitespace between these two lines (see c++ styleguide) - Alexander Rojas On April 18, 2016, 2:53 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46203/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 2:53 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/configuration.md cd9733002a0940f44edd4e56593a0ca3fe9f77f5 > include/mesos/authorizer/acls.proto > c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 > include/mesos/authorizer/authorizer.proto > 40d93ea257d1df8d22eee8a21667db90d579a8fe > src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 > src/authorizer/local/authorizer.cpp > c744a16041c2466d3839a37fbee2bf86887bf4e1 > src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315 > src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c > src/slave/slave.hpp f78c1b4e4d5378ef7223c6eb3ea45491c30fb4c1 > src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46203/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
