> On April 20, 2016, 10:35 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, line 151 > > <https://reviews.apache.org/r/46203/diff/9/?file=1350387#file1350387line151> > > > > Let's consider calling this `GetEndpoint`, to match the HTTP verb? > > There may be some users that are allowed to GET the endpoint at a > > particular path, but cannot POST to it.
You're right, follow up tickets will want to authorize `POST` actions and operators pretty sure will want them to be different from their `GET` acl. Will rename it to `GetEndpoint`. As a consequence `ACLs.acces_endpoints` will be renamed to `ACLs.get_endpoints` and `ACCESS_ENDPOINT_WITH_PATH` to `GET_ENDPOINTS_WITH_PATH`. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review129696 ----------------------------------------------------------- On April 22, 2016, 12:12 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46203/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 12:12 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > Added authorization of the '/flags' endpoint. > > > Diffs > ----- > > docs/configuration.md 86ba66ac62295ca148524bcb2e57fee560ac4ac5 > include/mesos/authorizer/acls.proto > c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 > include/mesos/authorizer/authorizer.proto > 40d93ea257d1df8d22eee8a21667db90d579a8fe > src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca > src/authorizer/local/authorizer.cpp > c744a16041c2466d3839a37fbee2bf86887bf4e1 > src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315 > src/slave/http.cpp f887a71684304a82ff0d81dbd240e29aa7e2ac67 > src/slave/slave.hpp 20a4bcd0bb9dad06ea81fc4ad9b2fa462c69d2c5 > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46203/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
