----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129570 -----------------------------------------------------------
src/CMakeLists.txt (line 55) <https://reviews.apache.org/r/45270/#comment193000> s/SPEC/STATE/? src/CMakeLists.txt (line 88) <https://reviews.apache.org/r/45270/#comment193001> Ditto. src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 27) <https://reviews.apache.org/r/45270/#comment193002> s/DockerVolumeMountList/DockerVolumeMounts/ src/slave/containerizer/mesos/isolators/docker/volume/state.proto (lines 32 - 46) <https://reviews.apache.org/r/45270/#comment193003> I still don't understand why we want to make it a protobuf? Can that just be a nested struct in the isolator? - Jie Yu On April 19, 2016, 3:04 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45270/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 3:04 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Added spec protobuf for DockerVolumeMount. > The DockerVolumeMount was used to check point the mount > point for each container to recover. > > > Diffs > ----- > > src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962 > src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac > src/slave/containerizer/mesos/isolators/docker/volume/state.proto > PRE-CREATION > > Diff: https://reviews.apache.org/r/45270/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
