----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129620 -----------------------------------------------------------
src/files/files.cpp (line 380) <https://reviews.apache.org/r/46373/#comment193055> Rather than logging this and setting the length to page size here, I think we would want to return a BadRequest response. src/files/files.cpp (line 426) <https://reviews.apache.org/r/46373/#comment193056> Negative offsets can be useful as well; for example, I could use {offset = -1024; length = 1024} to read the last 1024 bytes of the file. - Greg Mann On April 19, 2016, 8:07 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46373/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 8:07 a.m.) > > > Review request for mesos, Ben Mahler and Greg Mann. > > > Bugs: mesos-5060 > https://issues.apache.org/jira/browse/mesos-5060 > > > Repository: mesos > > > Description > ------- > > [MESOS-5060] > The patch did the following changes: > 1. Fix the offset and length logic in files.cpp. > 2. Add some tests to test the /files/read.json endponit with > negative offset or length. > > > Diffs > ----- > > src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 > src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd > > Diff: https://reviews.apache.org/r/46373/diff/ > > > Testing > ------- > > make > make check > > request 'files/read.json' endpoint with negative offset or length argument > > > Thanks, > > zhou xing > >
