-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/#review130342
-----------------------------------------------------------




src/files/files.cpp (line 362)
<https://reviews.apache.org/r/46373/#comment194066>

    I'm not sure that I like using -1 as a special number here. Perhaps we 
could use an `Option<size_t>` for `length`; see my comment below about this as 
well.



src/files/files.cpp (line 423)
<https://reviews.apache.org/r/46373/#comment194069>

    If `length` was an `Option<size_t>`, then we could check for 
`length.isNone()` here.



src/tests/files_tests.cpp (line 175)
<https://reviews.apache.org/r/46373/#comment194068>

    s/nagative/negative/


- Greg Mann


On April 20, 2016, 5:57 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46373/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Greg Mann.
> 
> 
> Bugs: mesos-5060
>     https://issues.apache.org/jira/browse/mesos-5060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [MESOS-5060]
> The patch did the following changes:
> 1. Fix the length logic in files.cpp.
> 2. Add some tests to test the /files/read.json endponit with
> negative length.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/46373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> request 'files/read.json' endpoint with negative offset or length argument
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Reply via email to