-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129637
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 63)
<https://reviews.apache.org/r/46293/#comment193110>

    Shouldn't this be `Try<ssize_t, SocketError>`? Here and below.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 65)
<https://reviews.apache.org/r/46293/#comment193108>

    Please use `ASSERT_TRUE` instead.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 66 - 68)
<https://reviews.apache.org/r/46293/#comment193109>

    This fits in one line.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 83)
<https://reviews.apache.org/r/46293/#comment193111>

    We should be looking at `result.error().code`. Here and below.


- Michael Park


On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [3/3] Updated `sendfile` test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to