-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129784
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 81 - 88)
<https://reviews.apache.org/r/46293/#comment193339>

    Sorry, from the `result.error().code` comment: by "Here and below" I also 
meant that we should use `result.error().message` rather than 
`os::strerror(_errno)`. Could you also update that please?


- Michael Park


On April 20, 2016, 4:54 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [4/4] Updated `sendfile` test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to