-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46435/#review129963
-----------------------------------------------------------




src/tests/containerizer/cni_isolator_tests.cpp (line 160)
<https://reviews.apache.org/r/46435/#comment193534>

    s/when the task is running/ once the task has been successfully launched. 
    
    s/, and/. It



src/tests/containerizer/cni_isolator_tests.cpp (line 169)
<https://reviews.apache.org/r/46435/#comment193535>

    We shouldn't need this since "network/cni" is enabled by default.



src/tests/containerizer/cni_isolator_tests.cpp (line 284)
<https://reviews.apache.org/r/46435/#comment193537>

    Can check for "resolv.conf" as well if we generate DNS info in the script.



src/tests/containerizer/cni_isolator_tests.cpp (line 297)
<https://reviews.apache.org/r/46435/#comment193544>

    This might become flaky. You can do something like this to explicitly 
detect that the executor has exited. 
    
https://github.com/apache/mesos/blob/master/src/tests/containerizer/isolator_tests.cpp#L1103


- Avinash sridharan


On April 20, 2016, 2:35 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46435/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
>     https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46435/diff/
> 
> 
> Testing
> -------
> 
> [ RUN      ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo
> I0420 22:34:55.747752 10309 exec.cpp:150] Version: 0.29.0
> I0420 22:34:55.768620 10328 exec.cpp:225] Executor registered on agent 
> e5403695-ee6e-435c-a273-b9523adf7051-S0
> Registered executor on mesos
> Starting task 51bf9caa-9305-4533-8ba5-1d7982d807b7
> sh -c 'sleep 1000'
> Forked command at 10332
> Received killTask for task 51bf9caa-9305-4533-8ba5-1d7982d807b7
> Sending SIGTERM to process tree at pid 10332
> Sent SIGTERM to the following process trees:
> [ 
> -+- 10332 sh -c sleep 1000 
>  --- 10333 sleep 1000 
> ]
> Command terminated with signal Terminated (pid: 10332)
> [       OK ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo (3090 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to