----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130099 -----------------------------------------------------------
src/master/http.cpp (line 335) <https://reviews.apache.org/r/46471/#comment193747> Can we use the same phrasing ("if the leading master cannot be found") here as we do below? src/master/http.cpp (line 690) <https://reviews.apache.org/r/46471/#comment193748> Lowercase "r" in "redirect", here and below. src/master/http.cpp (line 795) <https://reviews.apache.org/r/46471/#comment193750> "when the frameworks info is queried successfully." src/master/http.cpp (line 1175) <https://reviews.apache.org/r/46471/#comment193751> "Returns 200 OK when the request is processed successfully." src/master/http.cpp (line 1259) <https://reviews.apache.org/r/46471/#comment193752> "Returns 200 OK when the quota has been changed successfully." src/master/http.cpp (line 1307) <https://reviews.apache.org/r/46471/#comment193753> "Returns 200 OK when the weight update was successful." src/master/http.cpp (line 1350) <https://reviews.apache.org/r/46471/#comment193754> "Returns 200 OK when the state of the master was queried successfully." src/master/http.cpp (line 1706) <https://reviews.apache.org/r/46471/#comment193755> "Returns 200 OK when a summary of the master's state was queried successfully." src/master/http.cpp (line 1836) <https://reviews.apache.org/r/46471/#comment193756> "Returns 200 OK when information about roles was queried successfully." src/master/http.cpp (line 1957) <https://reviews.apache.org/r/46471/#comment193758> Not years, but "Returns 200 OK if the framework was torn down successfully." src/master/http.cpp (line 2054) <https://reviews.apache.org/r/46471/#comment193759> "Returns 200 OK when task information was queried successfully." src/master/http.cpp (line 2188) <https://reviews.apache.org/r/46471/#comment193749> "when maintenance successfully" is ungrammatical. "when the requested maintenance operation was performed successfully." src/master/http.cpp (line 2337) <https://reviews.apache.org/r/46471/#comment193760> "Returns 200 OK when the operation is successful." src/master/http.cpp (line 2453) <https://reviews.apache.org/r/46471/#comment193761> "Returns 200 OK when the operation is successful." src/master/http.cpp (line 2568) <https://reviews.apache.org/r/46471/#comment193762> "Returns 200 OK when the maintenance status was queried successfully." - Neil Conway On April 22, 2016, 7:18 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46471/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 7:18 a.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, > Neil Conway, and Vinod Kone. > > > Bugs: MESOS-1865 > https://issues.apache.org/jira/browse/MESOS-1865 > > > Repository: mesos > > > Description > ------- > > Update master endpoints descriptions about `TEMPORARY_REDIRECT` and > `SERVICE_UNAVAILABLE` when current master is not the leader. > > > Diffs > ----- > > src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 > > Diff: https://reviews.apache.org/r/46471/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
