> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > > > haosdent huang wrote: > Hi, @neilc. Thank you very much for your detail comments! I saw you use > `is xxed` in some comments while use `was xxed` in others. Should I change > all of them to `was xxed` to keep consistent? > > Neil Conway wrote: > Good point -- I don't have a strong preference on using "is" vs. "was", > but it would be good to pick one and use it consistently. I suppose "was" is > slightly more accurate?
Got it. Appreciated your comments again(you are the real author of this patch)! - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130099 ----------------------------------------------------------- On April 22, 2016, 3:48 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46471/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 3:48 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, > Neil Conway, and Vinod Kone. > > > Bugs: MESOS-1865 > https://issues.apache.org/jira/browse/MESOS-1865 > > > Repository: mesos > > > Description > ------- > > Update master endpoints descriptions about `TEMPORARY_REDIRECT` and > `SERVICE_UNAVAILABLE` when current master is not the leader. > > > Diffs > ----- > > src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 > > Diff: https://reviews.apache.org/r/46471/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
