----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130193 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 370) <https://reviews.apache.org/r/45375/#comment193885> s/volumeReference/references/ src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 372) <https://reviews.apache.org/r/45375/#comment193883> const Owned<Info>& Please make sure to use const ref if possible in all other places. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 373 - 374) <https://reviews.apache.org/r/45375/#comment193886> `foreach (const DockerVolume& volume, info->volumes)` src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 375 - 378) <https://reviews.apache.org/r/45375/#comment193887> This is not necessary if you define a hash function as I mentioned in the earlier patch. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 392) <https://reviews.apache.org/r/45375/#comment193888> s/dockerVolumeInfo/volume/ src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 394 - 395) <https://reviews.apache.org/r/45375/#comment193889> No needed. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 402) <https://reviews.apache.org/r/45375/#comment193891> You can avoid this loop. Just combine with the loop above. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 408) <https://reviews.apache.org/r/45375/#comment193894> "Unmounting ..." src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 412 - 414) <https://reviews.apache.org/r/45375/#comment193895> This is not needed any more. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 456) <https://reviews.apache.org/r/45375/#comment193896> for container <contianer_id> - Jie Yu On April 22, 2016, 4:13 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45375/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 4:13 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented cleanup() for docker volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > > Diff: https://reviews.apache.org/r/45375/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
