> On 四月 24, 2016, 5:47 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 418-419 > > <https://reviews.apache.org/r/45375/diff/8/?file=1358683#file1358683line418> > > > > containerDir contains the containerId, right?
Yes, but seems specifying the `containerId` is more clear as people can see the `containerId` if they are not familar with the checkpoint logic in dvd isolator, make sense? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130313 ----------------------------------------------------------- On 四月 24, 2016, 9:50 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45375/ > ----------------------------------------------------------- > > (Updated 四月 24, 2016, 9:50 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented cleanup() for docker volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > > Diff: https://reviews.apache.org/r/45375/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
