-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130197
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 120 - 
121)
<https://reviews.apache.org/r/45674/#comment193897>

    Copy paste error? Please remove the comments here.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 181 - 
185)
<https://reviews.apache.org/r/45674/#comment193900>

    Please do not copy the comments blindly. The comments here does not apply 
to this isolator. Please remove it.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 218)
<https://reviews.apache.org/r/45674/#comment193903>

    no need to introduce a separate file and parse funcition. Simply put the 
parsing logic here.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 225)
<https://reviews.apache.org/r/45674/#comment193907>

    s/dockerVolumes/volumes/



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 227)
<https://reviews.apache.org/r/45674/#comment193908>

    This is no longer needed per my comments in ealier patches.


- Jie Yu


On April 22, 2016, 7:15 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 7:15 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5104
>     https://issues.apache.org/jira/browse/MESOS-5104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented recover() for dvd isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.hpp 
> bc0c3299f9f3e351aaa20652b784bccbfd40c1a5 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45674/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to