> On 四月 22, 2016, 10:20 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 181-185 > > <https://reviews.apache.org/r/45674/diff/3/?file=1356492#file1356492line181> > > > > Please do not copy the comments blindly. The comments here does not > > apply to this isolator. Please remove it.
Seems this comment also fit to the `_recover` here well, as the `_recover` is also adding `Info` to `infos` and will not add it if the checkpoint directory was deleted. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130197 ----------------------------------------------------------- On 四月 22, 2016, 7:15 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45674/ > ----------------------------------------------------------- > > (Updated 四月 22, 2016, 7:15 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5104 > https://issues.apache.org/jira/browse/MESOS-5104 > > > Repository: mesos > > > Description > ------- > > Implemented recover() for dvd isolator. > > > Diffs > ----- > > src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 > src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > src/slave/containerizer/mesos/isolators/docker/volume/state.hpp > bc0c3299f9f3e351aaa20652b784bccbfd40c1a5 > src/slave/containerizer/mesos/isolators/docker/volume/state.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45674/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
