> On April 24, 2016, 12:40 p.m., haosdent huang wrote:
> >
> 
> haosdent huang wrote:
>     In additional, could you add @chenzhiwei and @vinodkone in reviewers? I 
> think powerpc could drop
>     
>     ```
>     #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__
>       // A workaround for powerpc. The magic number '203' is the syscall
>       // number for 'pivot_root' on the powerpc architecture, see
>       // https://w3challs.com/syscalls/?arch=powerpc_64
>       int ret = ::syscall(203, newRoot.c_str(), putOld.c_str());
>     ```
>     
>     as well. And you need fill a ticket for this in 
> https://issues.apache.org/jira/browse/MESOS and find a shepherd by sending 
> email to dev mailing list.
> 
> Tomasz Janiszewski wrote:
>     It looks like powerpc is properly handled with 
> [203](http://lxr.free-electrons.com/source/arch/powerpc/include/uapi/asm/unistd.h#L218)
> 
> Tomasz Janiszewski wrote:
>     Can we also drop
>     ```
>     #elif __x86_64__
>       // A workaround for systems that have an old glib but have a new
>       // kernel. The magic number '155' is the syscall number for
>       // 'pivot_root' on the x86_64 architecture, see
>       // arch/x86/syscalls/syscall_64.tbl
>       int ret = ::syscall(155, newRoot.c_str(), putOld.c_str());
>     ```
>     ?
>     If no then we probably can't drop powerpc and arm section.
> 
> haosdent huang wrote:
>     Yes, I think could remove as well. I double check x86, arm, arm64, 
> powerpc in 3.8 just now. `<linux/unistd.h>` already inlcudes them by 
> `<asm-generic/unistd.h>` or `<uapi/asm/unistd.h>`.
> 
> haosdent huang wrote:
>     By the way, we usually fill ticket number in `Bugs:       ` field in 
> review board. You can fill `MESOS-5263` it here.

I need @idownes and @chenzhiwei to help check whether we could drop it after 
add the correct header file.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46610/#review130303
-----------------------------------------------------------


On April 24, 2016, 11:36 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46610/
> -----------------------------------------------------------
> 
> (Updated April 24, 2016, 11:36 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix 'pivot_root is not available' error on ARM.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
> 
> Diff: https://reviews.apache.org/r/46610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to