Hi @idownes and @chenzhiwei. @Tomasz proposal to add the correct header file `<linux/unistd.h>` for pivot_root syscall. According my understand, we could drop these workaround code:
``` #elif __x86_64__ // A workaround for systems that have an old glib but have a new // kernel. The magic number '155' is the syscall number for // 'pivot_root' on the x86_64 architecture, see // arch/x86/syscalls/syscall_64.tbl int ret = ::syscall(155, newRoot.c_str(), putOld.c_str()); ``` ``` #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ // A workaround for powerpc. The magic number '203' is the syscall // number for 'pivot_root' on the powerpc architecture, see // https://w3challs.com/syscalls/?arch=powerpc_64 int ret = ::syscall(203, newRoot.c_str(), putOld.c_str()); ``` Would you help double check at your convenience? Thank you in advance. On Mon, Apr 25, 2016 at 9:00 AM, haosdent huang <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46610/ > > On April 24th, 2016, 12:42 p.m. UTC, *haosdent huang* wrote: > > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I think > powerpc could drop > > #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ > // A workaround for powerpc. The magic number '203' is the syscall > // number for 'pivot_root' on the powerpc architecture, see > // https://w3challs.com/syscalls/?arch=powerpc_64 > int ret = ::syscall(203, newRoot.c_str(), putOld.c_str()); > > as well. And you need fill a ticket for this in > https://issues.apache.org/jira/browse/MESOS and find a shepherd by > sending email to dev mailing list. > > On April 24th, 2016, 7:57 p.m. UTC, *Tomasz Janiszewski* wrote: > > It looks like powerpc is properly handled with 203 > <http://lxr.free-electrons.com/source/arch/powerpc/include/uapi/asm/unistd.h#L218> > > On April 24th, 2016, 8:19 p.m. UTC, *Tomasz Janiszewski* wrote: > > Can we also drop > > #elif __x86_64__ > // A workaround for systems that have an old glib but have a new > // kernel. The magic number '155' is the syscall number for > // 'pivot_root' on the x86_64 architecture, see > // arch/x86/syscalls/syscall_64.tbl > int ret = ::syscall(155, newRoot.c_str(), putOld.c_str()); > > ? If no then we probably can't drop powerpc and arm section. > > On April 25th, 2016, 12:32 a.m. UTC, *haosdent huang* wrote: > > Yes, I think could remove as well. I double check x86, arm, arm64, powerpc in > 3.8 just now. <linux/unistd.h> already inlcudes them by > <asm-generic/unistd.h> or <uapi/asm/unistd.h>. > > On April 25th, 2016, 12:36 a.m. UTC, *haosdent huang* wrote: > > By the way, we usually fill ticket number in Bugs: field in review board. You > can fill MESOS-5263 it here. > > I need @idownes and @chenzhiwei to help check whether we could drop it after > add the correct header file. > > > - haosdent > > On April 24th, 2016, 11:36 a.m. UTC, Tomasz Janiszewski wrote: > Review request for mesos and haosdent huang. > By Tomasz Janiszewski. > > *Updated April 24, 2016, 11:36 a.m.* > *Repository: * mesos > Description > > Fix 'pivot_root is not available' error on ARM. > > Diffs > > - src/linux/fs.cpp (2087b4ac1503e0fd085319b1017389f1f947536f) > > View Diff <https://reviews.apache.org/r/46610/diff/> > -- Best Regards, Haosdent Huang
