-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130755
-----------------------------------------------------------



I think need update the summary and the description as well. For example,

```
Used `<linux/unistd.h>` and clean up uncessary condition complie.
```

However, I am not a native speaker, this is up to you. :-)


src/linux/cgroups.cpp (line 27)
<https://reviews.apache.org/r/46730/#comment194633>

    I think we don't need change `cgroups.cpp`, right?
    
    Not yours, could you change the header files order like
    
    ```
    #include <glog/logging.h>
    
    #include <linux/unistd.h>
    
    #include <sys/types.h>
    ```



src/linux/ns.hpp (line 26)
<https://reviews.apache.org/r/46730/#comment194634>

    Add a line above.


- haosdent huang


On April 27, 2016, 9:46 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 9:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleanup syscalls logic.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to