----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/#review131233 -----------------------------------------------------------
Patch looks great! Reviews applied: [46807, 46858] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 29, 2016, 10:19 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46858/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 10:19 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, and Timothy Chen. > > > Bugs: MESOS-5239 > https://issues.apache.org/jira/browse/MESOS-5239 > > > Repository: mesos > > > Description > ------- > > In filesystem/linux isolator, we will need to make sure the mount that > contains the agent's working directory is a shared mount in its own > peer group so that cloning the host mount table (e.g., when launching > a container with a new mount namespace) does not create an extra > reference to the mounts under the agent's work_dir. > > However, if the mount containing the agent's working directory is > already a shared mount in its own peer group, we don't have to create > another bind mount for the agent's working directory. This patch > allows the filesystem/linux isolator to skip the bind mount if > possible. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > a6e748ae777b6280f5dab0a6fec7305f931f2c22 > > Diff: https://reviews.apache.org/r/46858/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
