> On May 2, 2016, 10:23 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 112-134 > > <https://reviews.apache.org/r/46858/diff/2/?file=1369065#file1369065line112> > > > > Why do we must alredy have a workdir mount in host mount table in the > > the very beginning? > > > > Any posibility that it does not exist?
Answered above. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/#review131380 ----------------------------------------------------------- On May 2, 2016, 9:04 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46858/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 9:04 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, and Timothy Chen. > > > Bugs: MESOS-5239 > https://issues.apache.org/jira/browse/MESOS-5239 > > > Repository: mesos > > > Description > ------- > > In filesystem/linux isolator, we will need to make sure the mount that > contains the agent's working directory is a shared mount in its own > peer group so that cloning the host mount table (e.g., when launching > a container with a new mount namespace) does not create an extra > reference to the mounts under the agent's work_dir. > > However, if the mount containing the agent's working directory is > already a shared mount in its own peer group, we don't have to create > another bind mount for the agent's working directory. This patch > allows the filesystem/linux isolator to skip the bind mount if > possible. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 8805143a2e5569a3479bbeab26cda12d2cd396a9 > src/tests/containerizer/filesystem_isolator_tests.cpp > 29d313051865761306029f331eb36684c3252ffb > > Diff: https://reviews.apache.org/r/46858/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
