-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review131464
-----------------------------------------------------------




src/tests/containerizer/docker_volume_isolator_tests.cpp (line 143)
<https://reviews.apache.org/r/46140/#comment195470>

    I would suggest using an `Owned` pointer here.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 216)
<https://reviews.apache.org/r/46140/#comment195472>

    Let's use `volume` while we dont have sth like volume2.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 230)
<https://reviews.apache.org/r/46140/#comment195471>

    ditto.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 277)
<https://reviews.apache.org/r/46140/#comment195473>

    ditto.


- Gilbert Song


On May 2, 2016, 10:12 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
>     https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test "ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume".
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 
> 070d52018e82ed3e46fb1b79714ffc4716f6a306 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46140/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to