> On May 4, 2016, 3:24 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/include/process/http.hpp, lines 89-91
> > <https://reviews.apache.org/r/46866/diff/1/?file=1368177#file1368177line89>
> >
> >     Is that the correct line-break here? Can we make it better?

I read through the relevant sections of our style guide and the Google style 
guide, and I can't find guidance on this specific situation. I played around 
with it for a bit and found a format that I think is more readable; let me know 
what you think.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review131613
-----------------------------------------------------------


On May 4, 2016, 9:18 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46866/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables libprocess to store and execute
> authorization callbacks provided by a client
> application.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46866/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to