> On May 9, 2016, 10:28 a.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/src/process.cpp, line 3289
> > <https://reviews.apache.org/r/46866/diff/4/?file=1375179#file1375179line3289>
> >
> >     Why no setting this variable close to were it will be used. I always 
> > liked the concept of data locality, so someone doesn't have to scroll up to 
> > see where a variable was set.

This needs to stay within the enclosing scope, but I moved it to the bottom of 
the `if` block, closer to `principal`'s first usage.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review132237
-----------------------------------------------------------


On May 10, 2016, 3:23 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46866/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 3:23 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables libprocess to store and execute
> authorization callbacks provided by a client
> application.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46866/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to