> On April 27, 2016, 8:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 13-42
> > <https://reviews.apache.org/r/46423/diff/2/?file=1358653#file1358653line13>
> >
> >     It seems like most of these are no longer necessary. Can we prune this 
> > a little bit, please?

Update: In the new changeset, these are mostly used now.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review130841
-----------------------------------------------------------


On May 3, 2016, 5:44 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 5:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
>     https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to